Active Record: automatic bulk method #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the below now automatically adds a `deliver_reminder_later_bulk` to `Invoice`:
```ruby
class Invoice < ActiveRecord::Base
performs def deliver_reminder
touch :reminded_at
end
end
```
So users can do `Invoice.all.deliver_reminder_later_bulk` or `Invoice.overdue.in_batches.each(&:deliver_reminder_later_bulk)`.
kaspth
commented
Sep 3, 2023
Comment on lines
+85
to
+93
| # Override Minitest::Test#run to wrap each test in a transaction. | ||
| def run | ||
| result = nil | ||
| ActiveRecord::Base.transaction(requires_new: true) do | ||
| result = super | ||
| raise ActiveRecord::Rollback | ||
| end | ||
| result | ||
| end |
There was a problem hiding this comment.
I had no idea it was this easy to wrap tests in a transaction!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 7.1,
ActiveJob.perform_all_laterwill push out jobs in bulk to a queue, and we can make that nicer for our jobs.Running the below now automatically adds a
deliver_reminder_later_bulktoInvoice:So users can do
Invoice.all.deliver_reminder_later_bulkorInvoice.overdue.in_batches.each(&:deliver_reminder_later_bulk).Ref: #4