Update railtie to set Oaken as the fixture replacement #80

tcannonfodder · 2024-06-26T11:54:18Z

See:

This fixes #58

* See: * https://github.com/search?q=repo%3Arails%2Frails%20fixture_replacement&type=code * https://github.com/search?q=repo%3Athoughtbot%2Ffactory_bot_rails%20fixture_replacement&type=code * https://github.com/thoughtbot/factory_bot_rails#generators

We don't have a fixture_replacement, so I don't think we should set that. I did some digging in the code and this invocation is the same as the previous commit when running with Rails' default test setup.

kaspth · 2024-06-28T15:11:42Z

lib/oaken/railtie.rb

+    config.app_generators do
+      _1.test_framework _1.test_framework, fixture: false
+    end


I dug around in the Rails internals and we can simplify the previous commit down to this. I'm still not sure if we should ship this in Oaken because of upgrading apps.

tcannonfodder requested a review from kaspth June 26, 2024 11:54

kaspth added 2 commits June 28, 2024 16:53

Disable Fixtures when using Oaken.

1396de7

We don't have a fixture_replacement, so I don't think we should set that. I did some digging in the code and this invocation is the same as the previous commit when running with Rails' default test setup.

Slight revert: hopefully handle RSpec with this version too

d732c58

kaspth reviewed Jun 28, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update railtie to set Oaken as the fixture replacement #80

Update railtie to set Oaken as the fixture replacement #80

tcannonfodder commented Jun 26, 2024 •

edited

Loading

kaspth Jun 28, 2024

Update railtie to set Oaken as the fixture replacement #80

Are you sure you want to change the base?

Update railtie to set Oaken as the fixture replacement #80

Conversation

tcannonfodder commented Jun 26, 2024 • edited Loading

kaspth Jun 28, 2024

Choose a reason for hiding this comment

tcannonfodder commented Jun 26, 2024 •

edited

Loading