Adapt to tidyr v1.0.0 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #195
jennybc
commented
Aug 1, 2019
| data, | ||
| test.func, formula = formula, | ||
| method = method, paired = paired, p.adjust.method = "none",...) | ||
| ) %>% |
There was a problem hiding this comment.
Doing this map() inside the mutate(), instead of outside, makes this code work for CRAN and dev versions of tidyr.
jennybc
commented
Aug 1, 2019
| @@ -233,6 +236,7 @@ compare_means <- function(formula, data, method = "wilcox.test", | |||
| by_y <- res %>% group_by(.y.) | |||
| pvalue.adj <- do(by_y, .p.adjust(., method = p.adjust.method)) | |||
| res <- res %>% | |||
| dplyr::ungroup() %>% | |||
There was a problem hiding this comment.
An explicit ungroup() here makes the code work for CRAN and dev versions of tidyr.
|
Thank you @jennybc for this contribution, highly appreciated! |
|
Great! So can you do a small release of ggpubr, in the near future? |
|
ggpubr is submitted now to CRAN |
|
Excellent! Thanks for doing attending to this in such a timely manner. |
|
You are welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #195
As mentioned in #195, the root issue here is that
tidyr::nest()now returns a grouped object, which has implications for downstream manipulations via, e.g., dplyr.