[WIP] Introduce Jenkins Job Builder for CI #344

wainersm · 2020-10-05T20:18:43Z

This change introduces the files and scripts to use with Jenkins
Job Builder to manage our CI jobs.

Fixes #343

Signed-off-by: Wainer dos Santos Moschetta wainersm@redhat.com

wainersm · 2020-10-05T20:20:18Z

Hi @GabyCT @chavafg , this PR is just a draft for the idea I proposed in #343 . If you think it is worth to adopt the tool, then I can manage to finish the implementation.

With this initial yaml files, the following jobs are generated:

# jenkins-jobs --conf jjb.conf list -p jobs/
INFO:root:Matching jobs: 8
kata-containers-agent-centos8-pr
kata-containers-agent-ubuntu1804-pr
kata-containers-osbuilder-centos8-pr
kata-containers-osbuilder-ubuntu1804-pr
kata-containers-runtime-centos8-pr
kata-containers-runtime-ubuntu1804-pr
kata-containers-tests-centos8-pr
kata-containers-tests-ubuntu1804-pr

jodh-intel

Hi @wainersm,

I like this idea a lot. Thanks very much for raising this!!

XML is terrible and YAML is quite the opposite imho :)

A few comments but this is a major improvement over the morass of XML spew which is frankly unreviewable.

jodh-intel · 2020-10-06T08:23:47Z

jjb/jobs/os2node.yaml.inc

+{% elif os == "centos8" -%}
+centos8_azure
+{% else %}
+unknown


ooi, what happens if we hit this condition?

jodh-intel · 2020-10-06T08:27:02Z

jjb/jobs/template.yaml

+
+                export GOPATH=$WORKSPACE/go
+                export GOROOT="/usr/local/go"
+                export PATH=${{GOPATH}}/bin:/usr/local/go/bin:/usr/sbin:/usr/local/bin:${{PATH}}


Could you use $GOROOT/bin here rather than hard-coding /usr/local/go/bin?

Should/usr/local/bin be "higher up" than /usr/sbin/?

To be honest I just copied the builder scripts from some of our current jobs, so I didn't pay attention to that kind of detail. I will fix it as we go.

Now that you asked, I noted that some jobs (maybe the majority?) simply clone the tests repo and call tests/.ci/jenkins_job_build.sh; others curl and execute tests/.ci/ci_entry_point.sh. So what's the ultimate entry point script for CI?

jodh-intel · 2020-10-06T08:27:54Z

jjb/jobs/template.yaml

+                export GOROOT="/usr/local/go"
+                export PATH=${{GOPATH}}/bin:/usr/local/go/bin:/usr/sbin:/usr/local/bin:${{PATH}}
+
+                cd $GOPATH/src/github.com/kata-containers/tests


cd "${{tests_repo_dir}}"

jjb/jobs/template.yaml

jodh-intel · 2020-10-06T08:30:34Z

jjb/publish_jobs.sh

+#
+# Use this script to publish the jobs on Jenkins.
+#
+


Script isn't set -e. How about also adding set -o nounset?

jodh-intel · 2020-10-06T08:30:44Z

jjb/jobs/template.yaml

+    builders:
+      - shell: |
+          #!/bin/bash
+          set -e


How about also adding set -o nounset? Also, is there a way to set a variable to enable tracing to work with out standard idiom of:

[ -n "${DEBUG:-}" ] && set -o xtrace

jjb/publish_jobs.sh

jodh-intel · 2020-10-06T08:33:07Z

jjb/publish_jobs.sh

+[ -n "$config_file" ] || usage
+
+readonly cmd="jenkins-jobs"
+command -V $cmd || echo "Needs $cmd command"


command -V "$cmd" >/dev/null ?

.gitignore

wainersm · 2020-10-09T18:16:09Z

Hi @wainersm,

I like this idea a lot. Thanks very much for raising this!!

XML is terrible and YAML is quite the opposite imho :)

A few comments but this is a major improvement over the morass of XML spew which is frankly unreviewable.

Ditto.

@jodh-intel I'm glad that you like the idea, it will really improve the management of jobs. I will be working on addressing your initial review but there are many decisions to take. We keep talking in this PR, is it okay for you?

This change introduces the files and scripts to use with Jenkins Job Builder to manage our CI jobs. Fixes kata-containers#343 Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

jodh-intel

Thanks @wainersm - a couple of comments.

btw, it helps if you add a comment to the PR once you've re-pushed so we get notified that it needs are view again ;)

I'm very keen that we switch to YAML config, particularly for Kata 2.x jobs due to the fact it's so much clearer and easier to review and understand the jobs. Can't wait to see this land!

/cc @amshinde.

jodh-intel · 2020-10-27T09:12:44Z

job-builder/jobs/dependencies.yaml

@@ -0,0 +1,68 @@
+---
+- job-template:
+    name: '{configuration}-nightly-x86_64'


Could you try to find a way to uses variables to avoid hard-coding architectures? Ideally, we'd be able to use this set of files for all architectures Kata runs on.

jodh-intel · 2020-10-27T09:14:21Z

job-builder/jobs/dependencies.yaml

+          [ -d "${{tests_repo_dir}}" ] || git clone "https://${{tests_repo}}.git" "${{tests_repo_dir}}"
+          ${{GOPATH}}/src/${{tests_repo}}/.ci/install_go.sh -p -f
+          pushd ${{tests_repo_dir}}
+          ./cmd/container-manager/manage_ctr_mgr.sh docker install -f


I wonder if it makes sense to leave the existing Jenkins XML config for Kata 1.x and just make the switch to YAML config for the 2.0-dev branch?

wdyt @GabyCT, @amshinde ?

jodh-intel · 2020-10-30T07:48:55Z

Ping @kata-containers/ci for more reviews.

wainersm · 2020-11-18T13:08:30Z

@jodh-intel Hi James! I'd like to let you know I didn't forget this! I am managing to get some time to resume this work, and I believe next week I will be able to.

jodh-intel · 2020-11-18T14:01:17Z

Thanks @wainersm ! 😄

jodh-intel · 2021-01-04T10:56:53Z

Added dnm label as we now have #359.

jodh-intel · 2021-10-25T13:06:08Z

@wainersm - can we close this as no longer required?

wainersm · 2021-10-25T14:45:17Z

Closed in favor of #359

jodh-intel reviewed Oct 6, 2020

View reviewed changes

jodh-intel added the release-gating Release must wait for this to be resolved before release label Oct 6, 2020

[WIP] Introduce Jenkins Job Builder for CI

aeedcaf

This change introduces the files and scripts to use with Jenkins Job Builder to manage our CI jobs. Fixes kata-containers#343 Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

wainersm force-pushed the introduce_jjb branch from 7a68787 to aeedcaf Compare October 13, 2020 21:36

jodh-intel reviewed Oct 27, 2020

View reviewed changes

jodh-intel mentioned this pull request Oct 30, 2020

jenkins: Add clh containerd k8s e2e job full #356

Merged

wainersm mentioned this pull request Dec 18, 2020

2.x - Introduce Jenkins Job Builder for CI #359

Merged

jodh-intel added the do-not-merge PR has problems or depends on another label Jan 4, 2021

jodh-intel mentioned this pull request Jul 9, 2021

Add an s390x job #387

Closed

wainersm closed this Oct 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Introduce Jenkins Job Builder for CI #344

[WIP] Introduce Jenkins Job Builder for CI #344

wainersm commented Oct 5, 2020

wainersm commented Oct 5, 2020 •

edited

Loading

jodh-intel left a comment

jodh-intel Oct 6, 2020

jodh-intel Oct 6, 2020

wainersm Oct 9, 2020

jodh-intel Oct 6, 2020

jodh-intel Oct 6, 2020

jodh-intel Oct 6, 2020

jodh-intel Oct 6, 2020

wainersm commented Oct 9, 2020

jodh-intel left a comment

jodh-intel Oct 27, 2020

jodh-intel Oct 27, 2020

jodh-intel commented Oct 30, 2020

wainersm commented Nov 18, 2020

jodh-intel commented Nov 18, 2020

jodh-intel commented Jan 4, 2021

jodh-intel commented Oct 25, 2021

wainersm commented Oct 25, 2021

[WIP] Introduce Jenkins Job Builder for CI #344

[WIP] Introduce Jenkins Job Builder for CI #344

Conversation

wainersm commented Oct 5, 2020

wainersm commented Oct 5, 2020 • edited Loading

jodh-intel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wainersm commented Oct 9, 2020

jodh-intel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jodh-intel commented Oct 30, 2020

wainersm commented Nov 18, 2020

jodh-intel commented Nov 18, 2020

jodh-intel commented Jan 4, 2021

jodh-intel commented Oct 25, 2021

wainersm commented Oct 25, 2021

wainersm commented Oct 5, 2020 •

edited

Loading