This repository has been archived by the owner on May 12, 2021. It is now read-only.
versions: Add gometalinter to versions database #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our tests CI is dependent on `gometalinter` which are run by the static checks script. However, `gometalinter` changes a lot and when it does, it breaks (what were) valid PRs. Add `gometalinter` to the versions database so we can pin the version we use to a known good one. Fixes kata-containers#304. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=========================================
- Coverage 64.35% 64.25% -0.1%
=========================================
Files 86 86
Lines 8430 8430
=========================================
- Hits 5425 5417 -8
- Misses 2429 2436 +7
- Partials 576 577 +1
Continue to review full report at Codecov.
|
|
This makes sense. LGTM It's weird that codecov says it impacts |
|
Yes, it's very odd and bogus fwics. I've raised kata-containers/tests#301 to investigate that issue, but I think this PR can be landed now (although it'll have to be forced due to the codecov complaint). |
|
Merge it regardless of codecov. |
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
A new field PciAddr has been added to grpc.Interface. This is the PCI identifier of the network device. In order to support network hotplug, we need to wait for the device to be online first based on the PCI address of the device inside the VM before updating its configuration. Fixes kata-containers#305 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests CI is dependent on
gometalinterwhich are run by the staticchecks script. However,
gometalinterchanges a lotand when it does, it breaks (what were) valid PRs.
Add
gometalinterto the versions database so we can pin the versionwe use to a known good one.
Fixes #304.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com