Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check condition before change #201

Merged
merged 1 commit into from
Apr 28, 2022
Merged

check condition before change #201

merged 1 commit into from
Apr 28, 2022

Conversation

airycanon
Copy link
Contributor

Changes

condition 没发生变化时，不需要更新，否则会导致 ready condition 的 lastTransitionTime 发生变化，频繁触发 reconcile。

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

@airycanon airycanon merged commit 7d19a7d into main Apr 28, 2022
@airycanon airycanon deleted the fix/check-condition-before-change branch April 28, 2022 03:16
@airycanon airycanon mentioned this pull request May 11, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfbm danielfbm danielfbm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@airycanon @danielfbm