Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add generic methods #230

Merged
merged 4 commits into from
Jul 26, 2022
Merged

feat: add generic methods #230

merged 4 commits into from
Jul 26, 2022

Conversation

l-qing
Copy link
Contributor

@l-qing l-qing commented Jul 25, 2022

Changes

  • feat: add generic methods
    • get secret by ref or labels
    • patch status and record event

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

@l-qing
feat: add generic methods
12d125c 
* get secret by ref or labels
* patch status and record event
@alaudabot
Copy link
Contributor

alaudabot commented Jul 25, 2022 •
edited
Loading

Quality Gate

updated at Tue Jul 26 02:40:53 UTC 2022

Status: OK 🟢

Metric Rating
🐛 Bugs: 0 🏗 Reliability: A 🟢
🤮 Code smells: 0 🛠 Maintainability: A 🟢
⚠️ Vulnerabilities: 0 🦺 Security: A 🟢
🔥 Security hotspots: 0 🔎 Security Review: A 🟢
Metric Change set Target (main) After
🧪 Code coverage 80.28%
Coverage on 71 new lines		 37.30% 37.80% ⬆️ 🟢
estimated after merge
allowed difference 0
👥 Duplications 0.00%
Duplications on 0 new lines		 0.20% 0.20% ↔️ 🟢
estimated after merge
allowed difference 0

[230]

l-qing
l-qing commented Jul 25, 2022
View reviewed changes
apis/meta/v1alpha1/resource_object_types.go Show resolved Hide resolved
errors/errors.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
patchstatus/patch_and_record.go Show resolved Hide resolved
testing/convert.go Outdated Show resolved Hide resolved
testing/kubernetes.go Outdated Show resolved Hide resolved
danielfbm
danielfbm previously approved these changes Jul 26, 2022
View reviewed changes
errors/errors.go Outdated Show resolved Hide resolved
testing/convert.go Outdated Show resolved Hide resolved
danielfbm
danielfbm previously approved these changes Jul 26, 2022
View reviewed changes
@l-qing l-qing merged commit 9f59f32 into main Jul 26, 2022
@l-qing l-qing deleted the feat/add-generic-methods branch July 26, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfbm danielfbm danielfbm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l-qing @alaudabot @danielfbm