Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add timeout function for check approval #257

Merged
merged 1 commit into from
Aug 24, 2022
Merged

feat: add timeout function for check approval #257

merged 1 commit into from
Aug 24, 2022

Conversation

l-qing
Copy link
Contributor

@l-qing l-qing commented Aug 24, 2022

Changes

  • feat: add timeout function for check approval

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Jeremy-boo
Jeremy-boo approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@Jeremy-boo Jeremy-boo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@alaudabot
Copy link
Contributor

Quality Gate

updated at Wed Aug 24 14:59:43 UTC 2022

Status: OK 🟢

Metric Rating
🐛 Bugs: 0 🏗 Reliability: A 🟢
🤮 Code smells: 0 🛠 Maintainability: A 🟢
⚠️ Vulnerabilities: 0 🦺 Security: A 🟢
🔥 Security hotspots: 0 🔎 Security Review: A 🟢
Metric Change set Target (main) After
🧪 Code coverage 100.00%
Coverage on 4 new lines		 44.40% 44.40% ↔️ 🟢
estimated after merge
allowed difference 0
👥 Duplications 0.00%
Duplications on 0 new lines		 0.20% 0.20% ↔️ 🟢
estimated after merge
allowed difference 0

[257]

@l-qing l-qing merged commit f81cf03 into main Aug 24, 2022
@l-qing l-qing deleted the feat/add-timeout-func branch August 24, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeremy-boo Jeremy-boo Jeremy-boo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l-qing @alaudabot @Jeremy-boo