Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add IsEmpty methods to AnalysisResult, CodeLintResults and Unit… #276

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

danielfbm
Copy link
Contributor

Changes

  • feat: Add IsEmpty methods to AnalysisResult, CodeLintResults and UnitTestResults

To avoid storing empty objects, the addition of these methods makes it super simple to verify if the object is empty or not and avoid using unpopulated data

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

…TestResults

To avoid storing empty objects, the addition of these methods makes
it super simple to verify if the object is empty or not and avoid
using unpopulated data
@danielfbm danielfbm force-pushed the feat/add-is-empty-methods-to-codequality branch from 058e742 to 5bd1939 Compare September 7, 2022 10:45
@danielfbm danielfbm merged commit 38dcb8f into main Sep 7, 2022
@danielfbm danielfbm deleted the feat/add-is-empty-methods-to-codequality branch September 7, 2022 11:12
@alaudabot
Copy link
Contributor

Quality Gate

updated at Wed Sep 7 11:19:18 UTC 2022

Status: OK 🟢

Metric Rating
🐛 Bugs: 0 🏗 Reliability: A 🟢
🤮 Code smells: 0 🛠 Maintainability: A 🟢
⚠️ Vulnerabilities: 0 🦺 Security: A 🟢
🔥 Security hotspots: 0 🔎 Security Review: A 🟢
Metric Change set Target (main) After
🧪 Code coverage 100.00%
Coverage on 16 new lines
50.90% 51.00% ⬆️ 🟢
estimated after merge
allowed difference 0
👥 Duplications 0.00%
Duplications on 0 new lines
0.20% 0.20% ↔️ 🟢
estimated after merge
allowed difference 0

[276]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants