Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add approval restrictions #283

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Conversation

l-qing
Copy link
Contributor

@l-qing l-qing commented Sep 19, 2022

Changes

feat: add approval restrictions requiresDifferentApprover

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

webhook/admission/approval_interface.go Show resolved Hide resolved
webhook/admission/approval_interface.go Show resolved Hide resolved
webhook/admission/approval_validate.go Outdated Show resolved Hide resolved
@alaudabot
Copy link
Contributor

alaudabot commented Sep 19, 2022

Quality Gate

updated at Mon Sep 19 10:22:51 UTC 2022

Status: OK 🟢

Metric Rating
🐛 Bugs: 0 🏗 Reliability: A 🟢
🤮 Code smells: 0 🛠 Maintainability: A 🟢
⚠️ Vulnerabilities: 0 🦺 Security: A 🟢
🔥 Security hotspots: 0 🔎 Security Review: A 🟢
Metric Change set Target (main) After
🧪 Code coverage 96.88%
Coverage on 32 new lines
51.50% 51.30% ⬇️ 🔴
estimated after merge
allowed difference 0
👥 Duplications 0.00%
Duplications on 0 new lines
0.20% 0.20% ↔️ 🟢
estimated after merge
allowed difference 0
  • ⚠️ Coverage change not allowed

[283]

danielfbm
danielfbm previously approved these changes Sep 19, 2022
@l-qing l-qing force-pushed the feat/add-approval-restrictions branch from da59e77 to 0c8b73e Compare September 19, 2022 09:50
@danielfbm danielfbm merged commit d5c0a60 into main Sep 19, 2022
@danielfbm danielfbm deleted the feat/add-approval-restrictions branch September 19, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants