Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add image option. #324

Merged
merged 2 commits into from
Dec 7, 2022
Merged

feat: add image option. #324

merged 2 commits into from
Dec 7, 2022

Conversation

kycheng
Copy link
Contributor

@kycheng kycheng commented Dec 6, 2022 •
edited
Loading

Changes

add image option

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

@alaudabot
Copy link
Contributor

alaudabot commented Dec 6, 2022 •
edited
Loading

Quality Gate

updated at Tue Dec 6 15:48:31 UTC 2022

Status: OK 🟢

Metric Rating
🐛 Bugs: 0 🏗 Reliability: A 🟢
🤮 Code smells: 0 🛠 Maintainability: A 🟢
⚠️ Vulnerabilities: 0 🦺 Security: A 🟢
🔥 Security hotspots: 0 🔎 Security Review: A 🟢
Metric Change set Target (main) After
🧪 Code coverage 90.79%
Coverage on 76 new lines		 54.80% 55.20% ⬆️ 🟢
estimated after merge
allowed difference 0
👥 Duplications 0.00%
Duplications on 0 new lines		 0.20% 0.20% ↔️ 🟢
estimated after merge
allowed difference 0

[324]

alaudabot
alaudabot reviewed Dec 6, 2022
View reviewed changes
artifacts/uri.go Outdated Show resolved Hide resolved
alaudabot
alaudabot reviewed Dec 6, 2022
View reviewed changes
artifacts/uri_test.go Outdated Show resolved Hide resolved
artifacts/uri.go Outdated Show resolved Hide resolved
@kycheng kycheng merged commit 2301bb8 into main Dec 7, 2022
@kycheng kycheng deleted the feat/image-option branch December 7, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaudabot alaudabot alaudabot left review comments

@danielfbm danielfbm danielfbm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kycheng @alaudabot @danielfbm