Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add base domain env key. #546

Merged
merged 2 commits into from
Mar 8, 2024
Merged

feat: add base domain env key. #546

merged 2 commits into from
Mar 8, 2024

Conversation

kycheng
Copy link
Contributor

@kycheng kycheng commented Mar 4, 2024 •
edited
Loading

Changes

feat: add base domain env key.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

chengjingtao
chengjingtao previously approved these changes Mar 6, 2024
View reviewed changes
@kycheng kycheng merged commit 808a415 into main Mar 8, 2024
0 of 2 checks passed
@kycheng kycheng deleted the feat/story3-4 branch March 8, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengjingtao chengjingtao chengjingtao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kycheng @chengjingtao