Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change UserApprovalInput approved field to pointer. #555

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix: change UserApprovalInput approved field to pointer. #555

merged 2 commits into from
Mar 12, 2024

Conversation

kycheng
Copy link
Contributor

@kycheng kycheng commented Mar 12, 2024 •
edited
Loading

Changes

fix: change UserApprovalInput approved field to pointer.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

@kycheng
Copy link
Contributor Author

kycheng commented Mar 12, 2024 •
edited
Loading

deliveries（@l-qing）/晋级 @kycheng 使用到的地方需要进行相应的修改。

@kycheng
Copy link
Contributor Author

kycheng commented Mar 12, 2024

由于包含breakchange，katanomi-pkg-downstream-test失败了，后续 @l-qing 会在deliveries 进行适配。
image

@kycheng kycheng merged commit 8380168 into main Mar 12, 2024
1 of 2 checks passed
@kycheng kycheng deleted the fix/approval-input branch March 12, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-qing l-qing l-qing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kycheng @l-qing