Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support update klog log level dynamically based on configmap #561

Merged
merged 1 commit into from
Mar 21, 2024
Merged

feat: support update klog log level dynamically based on configmap #561

merged 1 commit into from
Mar 21, 2024

Conversation

nanjingfm
Copy link
Contributor

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

chengjingtao
chengjingtao approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@chengjingtao chengjingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充一个spec 的文档， 先把这部分的 配置 在文档上写一下？

@nanjingfm
Copy link
Contributor Author

补充一个spec 的文档， 先把这部分的 配置 在文档上写一下？

done https://github.com/katanomi/spec/pull/299

@nanjingfm nanjingfm merged commit ede8aa5 into main Mar 21, 2024
2 checks passed
@nanjingfm nanjingfm deleted the feat/add-klog-config branch March 21, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengjingtao chengjingtao chengjingtao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanjingfm @chengjingtao