Make the taskRun sort stable #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzp1996
force-pushed
the
feat/modify-taskrun-sort
branch
from
9a1b09b
to
2a4d4c9
Compare
danielfbm
reviewed
May 27, 2024
TaskRun sort by completed time but if time is same then the sort is not stable. So if time is same then compare the namespace and name. Signed-off-by: yuzhipeng <zpyu@alauda.io>
yuzp1996
force-pushed
the
feat/modify-taskrun-sort
branch
from
2a4d4c9
to
12f54d4
Compare
danielfbm
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskRun sort by completed time but if time is same then the sort is not stable.
So if time is same then compare the namespace and name.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
specPR link includedfunctionality, content, code)
Release Notes