It's just some stuff! #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally use them.
My idea for finding this situation is a little cheesy, with a case like:
re -k str -r pcre -pl vmc '(.*)(\d*)'
the VM opcode list only contains one instruction, to immediately stop. So I'm detecting that. I think this suffices.
It might be more proper to walk the list of instructions looking for a "fetch", because that's what actually writes to a variable.
cratelyn
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small things, fixes, -Werror for retest, updating CI node dependencies, updating CI apt packages, this sort of stuff!