Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small refactor, removed unnecessary re-calculation #901

Merged
merged 1 commit into from
Jan 16, 2017

Conversation

jsphweid
Copy link

I noticed the calculation from progress to pos in updateProgress was already done in drawer's progress function, which I believe is the only place where updateProgress is called.

@katspaugh
Copy link
Owner

Good catch, thanks!

@katspaugh
Copy link
Owner

katspaugh commented Dec 22, 2016

Have you tested with different pixelRatios and with and without the scrollParent option?

@jsphweid
Copy link
Author

I just checked those on another computer (non-retina) and everything works as expected.

Although I must say I didn't touch in drawer.js under the comment /* Renderer-specific methods */ the line updateProgress: function (position) {} Honestly I didn't know what that was doing and hence didn't change it >.< Not sure if it matters.

@katspaugh
Copy link
Owner

It doesn't do anything, just a placeholder for "subclasses" to override.

@chrisparton1991
Copy link
Contributor

👍 Can this be merged, @katspaugh?

@katspaugh
Copy link
Owner

katspaugh commented Jan 10, 2017

Sorry, I haven't reviewed it in detail yet. I'll get to it ASAP.

@katspaugh katspaugh merged commit f9426cb into katspaugh:master Jan 16, 2017
@katspaugh
Copy link
Owner

Thanks!

mspae pushed a commit to mspae/wavesurfer.js that referenced this pull request Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants