Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable backgrounds for editor subwindow on certain filetypes #55

Closed
lovernj opened this issue Oct 31, 2022 · 4 comments · Fixed by #57
Closed

Disable backgrounds for editor subwindow on certain filetypes #55

lovernj opened this issue Oct 31, 2022 · 4 comments · Fixed by #57
Assignees

Comments

@lovernj
Copy link

lovernj commented Oct 31, 2022

Feature

When the currently open editor window matches a glob pattern (or a regex), turn off background customizations or set the opacity to 100%. Alternatively, a command palette option to set the opacity to 100% for the current editor window only.

Reason

My workflow heavily depends on editing and compiling $\LaTeX$ documents, which output as PDF. Having a pdf available to quickly check how code has compiled is super useful, but when this extension sets the opacity of the pdf viewer to <100%, the colors get funky and it doesn't resemble the final print as well. Being able to visually disable this extension for specific editor windows, or to start by having the extension disabled for those windows would be useful.

@lovernj
Copy link
Author

lovernj commented Oct 31, 2022

Just thinking about how you'd do this... Maybe add a special CSS id to the global CSS, kind of like what's going on in src/extension.ts, something like

#fullopac {
    opacity: 100%;
}

that overrides the opacity set by the class? Not sure how you'd get the currently active editor window, I'm not familiar with vscode api

@Katsute Katsute self-assigned this Nov 1, 2022
@Katsute
Copy link
Member

Katsute commented Nov 3, 2022

This issue is actually caused by how the extension renders backgrounds, I will try and see if I can get the background to render under images and pdfs.

@Katsute

This comment has been minimized.

@ghost

This comment has been minimized.

@Katsute Katsute linked a pull request Nov 5, 2022 that will close this issue
5 tasks
@ghost ghost locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants