Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo metadata to collect information about packages #600

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

xgreenx
Copy link
Contributor

@xgreenx xgreenx commented Jan 11, 2023

Instead of manually parsing the Cargo.toml use the cargo metadata command. It supports { workspace = true } syntax.

@xgreenx xgreenx force-pushed the feature/cargo-metadata-to-fetch branch from 4c98be4 to 8838486 Compare January 13, 2023 01:48
Copy link
Owner

@katyo katyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the minimum cargo version requirement? Please add note to README.

package.json Outdated Show resolved Hide resolved
src/package.ts Outdated Show resolved Hide resolved
src/package.ts Outdated Show resolved Hide resolved
@xgreenx xgreenx requested a review from katyo January 26, 2023 12:30
@katyo katyo merged commit 050b71d into katyo:main Jan 27, 2023
@katyo
Copy link
Owner

katyo commented Jan 27, 2023

@xgreenx I issued v2 which integrated this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants