-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed underscore as a dependency #27
Conversation
@dydx Thanks for the PR 👍 Travis is showing some errors with Node v5 / v4 any ideas? I think would be better to move |
As mentioned in the PR, those are just syntactical things (destructuring and arrow syntax). Relatively easy to downgrade. And yeah, moving code to 'core/helper.js' can be accomplished. |
@dydx Thanks for the help =) looks good to merge. |
OK. Moved Travis is happy now! |
@dydx I just published v2.0.7 to npm. Thanks again! feel free to submit other PR if you have any idea. |
@dydx We could make the lib even smaller by creating the data.json in benchmark.js since its a 10mb file. |
Maybe its better to just use https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package to ignore the benchmark folder |
Not that this is really a huge deal, but it was fairly straight forward. Zero dependencies now!
My update does require node >= 6.x.x. If there are requirements for using more legacy versions, I could pretty easily get that going as well, just a few syntax changes.