Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed underscore as a dependency #27

Merged
merged 4 commits into from
Jun 8, 2017

Conversation

dydx
Copy link
Contributor

@dydx dydx commented Jun 8, 2017

Not that this is really a huge deal, but it was fairly straight forward. Zero dependencies now!

My update does require node >= 6.x.x. If there are requirements for using more legacy versions, I could pretty easily get that going as well, just a few syntax changes.

@kaue
Copy link
Owner

kaue commented Jun 8, 2017

@dydx Thanks for the PR 👍

Travis is showing some errors with Node v5 / v4 any ideas?

I think would be better to move helpers.js to core/helper.js

@dydx
Copy link
Contributor Author

dydx commented Jun 8, 2017

As mentioned in the PR, those are just syntactical things (destructuring and arrow syntax). Relatively easy to downgrade.

And yeah, moving code to 'core/helper.js' can be accomplished.

@kaue
Copy link
Owner

kaue commented Jun 8, 2017

@dydx Thanks for the help =) looks good to merge.

@dydx
Copy link
Contributor Author

dydx commented Jun 8, 2017

OK. Moved lib/helpers.js into lib/core/helper.js and removed the object destructuring; e.g. const { isArray } = require('./helpers.js');

Travis is happy now!

@kaue kaue merged commit d4e8eb9 into kaue:master Jun 8, 2017
@kaue
Copy link
Owner

kaue commented Jun 8, 2017

@dydx I just published v2.0.7 to npm.

Thanks again! feel free to submit other PR if you have any idea.

@kaue
Copy link
Owner

kaue commented Jun 8, 2017

@dydx We could make the lib even smaller by creating the data.json in benchmark.js since its a 10mb file.

@kaue
Copy link
Owner

kaue commented Jun 8, 2017

Maybe its better to just use https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package to ignore the benchmark folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants