-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add handleHeaders option #54
Conversation
what’s the difference from rename & headers options? Thanks for the contribution :) |
@kauegimenes my use case is to strip a prefix from headers where it exists. It doesn't seem like the rename option supports that. Example Array input
Example implementation
Example CSV output
|
I see. Looks good to merge for me, any input @AckerApple ? |
I'm hella busy today. I sorta understand the need |
@AckerApple I will merge this later today and publish to npm if you don't have any objections handleHeaders: (header) => header.replace(/prefix[0-9]\./, '') Also add your name to the README contributors list =) |
It maybe too late for this BUT I really think a parent-name argument should be added
This doesn't have to be done and I have a meeting to get into that I can't further explain. |
@kauegimenes I'll do that tonight, thanks! @AckerApple I think I understand what you're getting at; will take a stab at that too. |
Sorry for the delay guys, i didn’t notice your commit jason :/ |
@kauegimenes no worries -- I'm good on my end |
Nice! thanks for creating this PR :) I will publish v2.3 in a few hours. |
@jasonmacgowan I just published v2.3 in NPM Thanks for your contribution, feel free to create more PRs in the future, welcome to the team. |
Status
READY
Description
Allow headers to be transformed by end user.
Related PRs
List related PRs against other branches:
Todos
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
Impacted Areas in Application
List general components of the application that this PR will affect: