Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: null check to prevent error spam #35

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

thakyZ
Copy link
Contributor

@thakyZ thakyZ commented Jul 25, 2024

There is a error log spam when the AtkResNode* passed to the method GetNodeIconArray has the method GetAsAtkComponentNode() called and returns null thus unable to get the Component then UldManager.

@thakyZ
Copy link
Contributor Author

thakyZ commented Jul 25, 2024

Also as a side note, more null checks may be necessary but I am unsure of this.

@Limiana
Copy link
Collaborator

Limiana commented Jul 25, 2024

Thank you! Why would it be null though? Might be better to investigate underlying issue.

@Limiana Limiana merged commit fb9878e into kawaii:main Jul 25, 2024
@thakyZ
Copy link
Contributor Author

thakyZ commented Jul 26, 2024

I am unsure as to why, but it may be helpful for other plugin authors so that this mod isn't spamming the logs. Because the party list is completely shown when it errors so not sure as to why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants