Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirection is not working after click to Accept #4

Open
Eldenroot opened this issue May 25, 2018 · 8 comments
Open

Redirection is not working after click to Accept #4

Eldenroot opened this issue May 25, 2018 · 8 comments

Comments

@Eldenroot
Copy link

Eldenroot commented May 25, 2018

Maybe would be nice to redirect user to the main page (or configurable URL)

@dvz
Copy link
Collaborator

dvz commented May 26, 2018

Take a look at the value for the url_before_redirect form field (basing on $_SERVER['HTTP_REFERER']) on the Accept page, respected if this condition is met:
https://github.com/kawaii/mybb-amnesia/blob/15e2115/inc/plugins/amnesia/hooks_frontend.php#L307

@Eldenroot
Copy link
Author

Eldenroot commented May 27, 2018

@dvz - ok, there is an issue if the user does not have any "previous pages" visited, so the redirect returns back to GDPR page over and over. Maybe would be nice in that cases to redirect this user to forum homepage.

@dvz
Copy link
Collaborator

dvz commented May 27, 2018

It should redirect to Board URL, unless it's not not set properly; another reason for a loop is an update date set in the future (in this case the Accept button would keep appearing).

@IntoxNitram
Copy link

Yeah I think it's not working properly. I have a date set in the past and if the user logs in and has to accept it just accepts but redirects to the policy page again (no accept button).

@andrewjs18
Copy link

I personally cannot duplicate this...it seems to work as expected for me on a test board with no other plugins installed.

that being said, I did notice that when you turn off friendly redirects and you accept the new policy, it does not remove the message until you click on another part of the site to get it to load a new page. this could probably be fixed, I assume, by forcing the page to go to the board url after a user clicks 'accept' if they have friendly redirects turned off.

@IntoxNitram
Copy link

It’ll probably be the friendly redirects bit then, as I have that turned off on my forum.

@andrewjs18
Copy link

weird..the message did go away after clicking 'accept' this time with friendly redirects turned off. earlier it wasn't.

this is what it'd look like earlier after accepting the policy with the redirects turned off:

2018-05-28 16_55_36

@IntoxNitram
Copy link

Yep it seems inconsistent I’ve just tried it again on another account on my live forum and it redirected correctly back to the index this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants