Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide progress bar on shallow routing #278

Merged
merged 6 commits into from
Jul 21, 2021

Conversation

ekamuktia
Copy link
Collaborator

@ekamuktia ekamuktia commented Jul 21, 2021

Closes #277

Description

Check if the router event is shallow event, if yes then do not start nprogress

Current Tasks

  • Update router event to start nprogress only for non shallow event
  • Test on province, contact, and faq page by changing keyword, filter, and sort
  • Add screen recording from testing

Province List
ezgif com-gif-maker

Contact List
ezgif com-gif-maker (1)

FAQ
ezgif com-gif-maker (2)

@netlify
Copy link

netlify bot commented Jul 21, 2021

✔️ Deploy Preview for wargabantuwarga ready!

🔨 Explore the source changes: 5b1977c

🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/60f84f474290030008efff6d

😎 Browse the preview: https://deploy-preview-278--wargabantuwarga.netlify.app

@ekamuktia ekamuktia marked this pull request as draft July 21, 2021 15:43
pages/_app.tsx Outdated Show resolved Hide resolved
@ekamuktia ekamuktia marked this pull request as ready for review July 21, 2021 16:34
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@resir014 resir014 enabled auto-merge July 21, 2021 16:46
Copy link
Member

@mazipan mazipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✅

A simple touch

@resir014 resir014 merged commit c304f01 into kawalcovid19:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide progress bar on shallow routing
3 participants