Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension is now asking read/write permission on all websites? #36

Closed
u1735067 opened this issue Jan 23, 2024 · 8 comments
Closed

Extension is now asking read/write permission on all websites? #36

u1735067 opened this issue Jan 23, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@u1735067
Copy link

u1735067 commented Jan 23, 2024

Hello,

it seems the latest version(s?) (0.8.0) is now asking read/write permission on all websites, is that expected?
Previously it was only asking for the websites set in

"manifest": {
"host_permissions": [
"https://bsky.social/*",
"https://twitter.com/*",
"https://x.com/*"
],

Best,

@ShawnBowman
Copy link

Yep I'm seeing this too. The extension got auto-disabled because of it and I'm concerned about turning it back on.

@kawamataryo
Copy link
Owner

I didn't change the permissions...why is that?

https://github.com/kawamataryo/sky-follower-bridge/blob/main/package.json#L53-L57

I'll look into it.

@kawamataryo
Copy link
Owner

kawamataryo commented Jan 23, 2024

This is the difference in the generated manifest.json from the previous version.

CleanShot 2024-01-24 at 04 51 35

The addition of web_accessible_resources may be the cause of this issue..

@kawamataryo kawamataryo self-assigned this Jan 23, 2024
@kawamataryo
Copy link
Owner

I will try to fix it so that it does not need unnecessary permissions.

@kawamataryo
Copy link
Owner

kawamataryo commented Jan 24, 2024

I found that either a bug in the build tool or an unnecessary web_accessible_resources permission was introduced and this was the cause of this Issue.

Fixed in the following commit.

2721ee9
(Not a good way to...)

Unnecessary permissions will no longer be required with the 0.8.1 release.

@kawamataryo kawamataryo added the bug Something isn't working label Jan 24, 2024
@kawamataryo
Copy link
Owner

8.1 was released, but not fixed...😢
I will try to fix again.

@kawamataryo
Copy link
Owner

I fixed it again in version 8.2.

image

@u1735067
Copy link
Author

Fixed for me, thanks, and thank you for the extension too btw 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants