Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using totals throws exception #70

Closed
twheys opened this issue Dec 5, 2016 · 0 comments
Closed

Using totals throws exception #70

twheys opened this issue Dec 5, 2016 · 0 comments

Comments

@twheys
Copy link
Contributor

twheys commented Dec 5, 2016

All requests using totals results in an exception

File "/Users/llira/.virtualenvs/dashmore/lib/python3.4/site-packages/fireant/slicer/managers.py", line 395, in _get_and_transform_data
   display_schema = self.manager.display_schema(metrics, dimensions, references, operations)
 File "/Users/llira/.virtualenvs/dashmore/lib/python3.4/site-packages/fireant/slicer/managers.py", line 153, in display_schema
   'metrics': self._display_metrics(metrics, operations),
 File "/Users/llira/.virtualenvs/dashmore/lib/python3.4/site-packages/fireant/slicer/managers.py", line 324, in _display_metrics
   metric_key = getattr(operation, 'metric_key')
AttributeError: 'Totals' object has no attribute 'metric_key'
twheys added a commit that referenced this issue Dec 5, 2016
@twheys
Fixes #70 Fixed the getattr expression for operations so that it can …
ebf2d97 
…handle a missing metric_key such as in the case of Totals
@twheys twheys mentioned this issue Dec 5, 2016
Merged
@twheys twheys closed this as completed in #71 Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twheys