Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas.read_sql returns DF with binary string col names #9

Merged
merged 4 commits into from
Aug 12, 2016

Conversation

twheys
Copy link
Contributor

@twheys twheys commented Aug 12, 2016

  • Converted the column names to unicode
  • Added test coverage for highcharts and datatables data point formatter functions
  • Added test coverage for database.fetch_dataframe
  • Fixed checks for np.nan to use np.isnan instead of value is np.nan

…binary string column names instead of unicode. Also added more test coverage to the data point formatters in highcharts and datatables
@coveralls
Copy link

coveralls commented Aug 12, 2016

Coverage Status

Coverage increased (+0.04%) to 95.96% when pulling 03aa17e on binary_cols_from_read_sql into ab23ef7 on master.

…ems that they are str in notebooks but bytes elsewhere.
@coveralls
Copy link

coveralls commented Aug 12, 2016

Coverage Status

Coverage increased (+0.04%) to 95.96% when pulling f543597 on binary_cols_from_read_sql into ab23ef7 on master.

@coveralls
Copy link

coveralls commented Aug 12, 2016

Coverage Status

Coverage increased (+0.05%) to 95.962% when pulling 54dc668 on binary_cols_from_read_sql into ab23ef7 on master.

@twheys twheys merged commit a70d11d into master Aug 12, 2016
@twheys twheys deleted the binary_cols_from_read_sql branch August 12, 2016 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants