Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix columns with empty args #431

Merged
merged 1 commit into from
May 5, 2020
Merged

Fix columns with empty args #431

merged 1 commit into from
May 5, 2020

Conversation

hqsz
Copy link
Contributor

@hqsz hqsz commented May 5, 2020

Fix columns with empty arguments. I occurs by #373 that support iterable params to columns
Really sorry for the hasty PR 😥 ...

Fixed: #430

@hqsz hqsz requested review from twheys and a team as code owners May 5, 2020 11:50
@coveralls
Copy link

coveralls commented May 5, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 97.809% when pulling 4c177e8 on lntuition:fix_empty_args_to_columns into a8348a2 on kayak:master.

@hqsz hqsz mentioned this pull request May 5, 2020
Open
@mikeengland mikeengland merged commit 8f2ba12 into kayak:master May 5, 2020
@mikeengland
Copy link
Contributor

Thanks for the contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twheys twheys Awaiting requested review from twheys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with empty argument columns
3 participants
@hqsz @coveralls @mikeengland