Skip to content

Latest commit

 

History

History
138 lines (94 loc) · 8 KB

CONTRIBUTING.md

File metadata and controls

138 lines (94 loc) · 8 KB
Raw

Contributing

Hi there! We're thrilled that you'd like to contribute to this project. Your ideas are essential for keeping making it better :)

Contributor License Agreement

Atlassian must have a Contributor License Agreement (CLA) on file from each individual or corporation contributing to our open-source projects. The CLA allows contributors to maintain ownership in the IP of their contributions while granting Atlassian the rights to control and maintain our projects.

Submit an individual CLA or a corporate CLA.

License & Code of Conduct

Contributions to this project releases to the public under our open source license.

Please note that this project has a Contributor Code of Conduct. By participating in this project you agree to abide by its terms.

Getting Started

This app is written in Typescript and runs on Node.js v14.x.

Please install Docker and Docker Compose to easily run the project locally.

Create your Jira instance

Create a new free developer instance on Jira Cloud.

Configuring a GitHub App

Create a new GitHub App, setting the following config:

Domain refers to the URL for the local domain obtained after tunneling. If the tunnel is created from atlas, then it would be something like https://__MYDOMAIN__.public.atlastunnel.com. But if the tunnel is created from ngrok, then https://XXXX-XXX-XXX-XXX-xX.ngrok.io.

  • GitHub App name: Anything you want, but it must be unique across GitHub
  • Homepage URL: https://github.com/apps/GITHUB_APP_NAME (The full URL to your GitHub App’s website)
  • Callback URL: https://DOMAIN/github/callback
  • Setup URL: https://DOMAIN/github/setup
  • Webhook URL: https://DOMAIN/github/webhooks
  • Webhook Secret: development

Your new GitHub app will need the following repository permissions & events:

Repository Permissions:

  • Actions: Read-only
  • Code scanning alerts: Read-only
  • Contents: Read & Write
  • Deployments: Read-only
  • Issues: Read & write
  • Metadata: Read-only
  • Pull requests: Read & write

Organization Permissions:

  • Members: Read-Only

Subscribe to Events:

  • Code scanning alert
  • Commit comment
  • Create
  • Delete
  • Deployment status
  • Issue comment
  • Issues
  • Pull request
  • Pull request review
  • Push
  • Repository
  • Workflow run

Setting up your environment file

The environment files work in a fairly standardized way of having a "global" .env that holds information needed across all environments but is not committed. Then we have NODE_ENV specific environment files like .env.development, .env.test, etc, as they are non-sensitive default variables needed for those environments to work. Since they are committed, please be careful not to add sensitive information to these files - if you need to add sensitive information or you want to overwrite the environment defaults, you can create a .local version of that file and that will never be committed.

Once you've set up your GitHub app and cloned this repo, copy the file .env.development.local-example to a new file called .env.development.local. Fill in the blank fields in the file:

  • APP_ID and GITHUB_CLIENT_ID: Copy these values over from your new GitHub app page.
  • GITHUB_CLIENT_SECRET: You'll need to generate a new one on your GitHub app page by hitting the Generate a new client secret button. Copy and paste the generated secret.
  • PRIVATE_KEY_PATH: You'll also need to generate a new private key on your GitHub app page, download it, move it to the source root of this repo, and set PRIVATE_KEY_PATH=<your-private-key-name>.pem
  • ATLASSIAN_URL: The URL for the Jira instance you're testing on. If you don't have one now, please set the value of this variable from the steps mentioned here.
  • INSTANCE_NAME: Your Jira app name - will show as "GitHub for Jira (instance-name)"

Lastly, you need to replace the value of the follow variables in the global .env file:

  • NGROK_AUTHTOKEN: Your ngrok authtoken. If you want to use ngrok as a tunnel to test it on your Jira instance, you need an authtoken. Simply login/signup to ngrok, copy & paste the authtoken into this var.

Running the app

The first time you run the app, simply run:

yarn install # installs node modules
docker-compose up # Spin up docker containers

That's it. Everything is ran in docker-compose, including redis, postgres, ngrok and the app (main and worker thread). If you want to debug, you can connect to the remote port of 9229 for the main thread and 9230 for the worker thread in docker. Any changes to the code will restart the node server automatically. For tests, run yarn test. If you want to run a different tunneling tool, run docker-compose up app instead as it will only bring up the app and its dependencies (redis & postgres). You can then run you tunnelling tool to point to http://app:8080.

Installing the App

Go to your Jira instance that you created earlier and do the following steps:

  1. From the header menu, select Apps -> Manage your apps.
  2. Verify the filter is set to User-installed, and select Settings beneath the User-installed apps table.
  3. On the Settings pop-up, add Enable development mode and click Apply. Refresh the page.
  4. On the right side of the header, there should now appear a button Upload app. Click it and enter https://DOMAIN/jira/atlassian-connect.json
  5. Click Upload.
  6. That's it! You're done. 🎉

Setting up the App

In your Jira instance, in the Manage Apps section, click on your App's button, then click on Get Started. This will bring you to the App's dashboard. Click the Add an Organization button and follow the steps to install the App on GitHub and allow it permission to view your repos.

After this is done, you should see your repos starting to sync in the App's dashboard.

Accessing Admin Endpoints

There are some admin endpoints that require special permissions (see viewerPermissionQuery in /src/api/backfill.types.ts).

To call these endpoints, you must:

  • be an admin in a special GitHub org
  • create a personal access token in your GitHub settings and pass it in the Authorization header as Bearer <token>.

Contributing

Thank you so much for willing to contribute to this project!

Before you spend time working on something, it might be worth discussing your changes with other contributors before starting for guidance and potentially combining efforts with other members. Remember to try to keep your changes simple and concise - do not try to fix everything in one Pull Request. We'd much appreciate multiple smaller PRs over one massive one. We're also here to help, so if you're stuck or blocked, please feel free to reach out.

That being said, here are the steps needed to create a Pull Request for us to review:

  1. Sign the CLA first!
  2. Fork the repository.
  3. Do your changes either on the main branch or create a new one.
  4. Make sure the tests pass on your machine with yarn test and the build works with yarn run build. If you're adding new functionality, please add tests to reflect this.
  5. Commit and Push your changes - verify it passes all checks.
  6. Submit your pull request with a detailed message about what's changed.
  7. Wait for us to review and answer questions/make changes where requested.
  8. Once merged, celebrate with your drink of choice because you've just helped thousands (if not millions) of people get a better experience in both Jira and GitHub! 🍻