Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thyseus-0.14] Upgrade to Thyseus 0.14 #118

Merged
merged 24 commits into from
Sep 4, 2023
Merged

[thyseus-0.14] Upgrade to Thyseus 0.14 #118

merged 24 commits into from
Sep 4, 2023

Conversation

JaimeGensler
Copy link
Collaborator

So far this just removes uses of initStruct, dropStruct, and the old @struct API. Haven't actually handled the version bump as I'm not sure the correct/best way to do that

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2023

⚠️ No Changeset found

Latest commit: 6fff9db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lattice ❌ Failed (Inspect) Aug 7, 2023 3:14am

@@ -33,10 +33,10 @@ export class TransformControlsStore {

@struct
export class CanvasRect {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initialization here is probably what caused the most recent tab freezing you saw, by the way. Previous API wasn't tolerant of this, new one is 😄


/**
* The currently pressed keys.
* Each index is a `Key` enum value.
* The value is `1` if the key is pressed, `0` otherwise.
*/
@struct.array({ length: NUM_KEYS, type: "u8" }) declare keys: Uint8Array;
#keys: u64 = 0n;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to handle this differently to keep the type from being massive and to reduce the memory footprint of it (not that it matters too much for resources), obviously feel free to handle this however you'd like 😃

Copy link
Owner

@kayhhh kayhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kayhhh kayhhh merged commit 25e07df into main Sep 4, 2023
1 check failed
@kayhhh kayhhh deleted the jgens--thyseus-0.14 branch September 4, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants