-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[thyseus-0.14] Upgrade to Thyseus 0.14 #118
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -33,10 +33,10 @@ export class TransformControlsStore { | |||
|
|||
@struct | |||
export class CanvasRect { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initialization here is probably what caused the most recent tab freezing you saw, by the way. Previous API wasn't tolerant of this, new one is 😄
packages/input/src/resources.ts
Outdated
|
||
/** | ||
* The currently pressed keys. | ||
* Each index is a `Key` enum value. | ||
* The value is `1` if the key is pressed, `0` otherwise. | ||
*/ | ||
@struct.array({ length: NUM_KEYS, type: "u8" }) declare keys: Uint8Array; | ||
#keys: u64 = 0n; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opted to handle this differently to keep the type from being massive and to reduce the memory footprint of it (not that it matters too much for resources), obviously feel free to handle this however you'd like 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
So far this just removes uses of
initStruct
,dropStruct
, and the old@struct
API. Haven't actually handled the version bump as I'm not sure the correct/best way to do that