fixes for #92 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of defining them from scratch, we simply read them from the .odx-cs fragments shipped with the ODX standard. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
kayoub5
reviewed
Nov 15, 2022
…e is defined ... some of the comparam fragments shipped with the ODX standard only specify a unit without any scaling. Assuming that these files are correct, we should not complain about this either? Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the main change is a fix for the complaints about the missing communication parameters in somersaultecu: instead of defining them from scratch, we simply read them from the .odx-cs fragments shipped with the ODX standard.
besides this, there was a wrong name in a reference to a commparam and some warning in
units.pywhich stemmed from the fact that the comparam fragments shipped with the standard specify a unit with a physical dimension but without a scaling.Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information