Fix Hmisc continuous variables treated as factors. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variable. Class double had to be added to the continous classes.
|
Thank you so much for figuring this out and solving it! The changes look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kaz-yos,
the fix from #64 worked. But while testing variables labelled with labelled or haven I did run into another problem. If you add value labels to numeric variables the class changes to double. I'm quite surprised this was not a problem earlier. I extended an existing test to check for this.
Fixes #57, fixes #64.
Greetings,
Alex
PS: I went through the issues. Can #21, #43 and #61 be closed?