Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving naming tracking into Jim class from Prior class #98

Closed
kazewong opened this issue Jul 22, 2024 · 1 comment
Closed

Moving naming tracking into Jim class from Prior class #98

kazewong opened this issue Jul 22, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@kazewong
Copy link
Owner

kazewong commented Jul 22, 2024

Currently tracking the naming of parameters is done within the prior class, which limits the flexibility and legibility of parameters within Jim.

It is probably more ergonomic to define parameters and track their naming within Jim, and specify transform only at the interface with the likelihood object and prior object.

This should solve the problem specified in #89 .

@thomasckng
Copy link
Collaborator

This should fix the problem in #81 as long as all the prior are sample from the unconstrained uniform. nanargmin in the line below should be changed back to argmin after the implementation.

best_fit = optimized_positions[jnp.nanargmin(summary["final_log_prob"])]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants