Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating run-manager #107

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Updating run-manager #107

merged 10 commits into from
Jul 26, 2024

Conversation

xuyuon
Copy link
Contributor

@xuyuon xuyuon commented Jul 25, 2024

  • The SingleEventRun no longer requires injection parameters if you are not performing an injection run (i.e., injection=False). It will now raise a ValueError if no injection parameters are provided when initializing SingleEventPERunManager with injection turned on.
  • Added a plot_corner() function to plot the posterior samples in a corner plot
  • Added a plot_diagnostic() function to plot the loss values, log probability, global acceptance rate, local acceptance rate of the run over iterations.
  • Updated Single_event_runManager.py to show how the plotting function works

@xuyuon xuyuon changed the base branch from main to jim-dev July 25, 2024 13:14
@ThibeauWouters ThibeauWouters mentioned this pull request Jul 26, 2024
10 tasks
@kazewong kazewong self-requested a review July 26, 2024 17:12
@kazewong kazewong added the enhancement New feature or request label Jul 26, 2024
Copy link
Owner

@kazewong kazewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tho the priors used here may need to rework after #98

@kazewong kazewong merged commit 93b6dc9 into kazewong:jim-dev Jul 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants