Handling nan output from Adam optimizer when generating reference parameters #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to generate a set of reference parameters for the heterodyning likelihood, the output list of log likelihood often contains some
nan
values. When we try to search for the minimum log likelihood usingargmin()
on a list containingnan
values, it will result in a list ofnan
as the reference parameters, causing the program to run into a bug. I think it would be a better idea to replaceargmin()
withnanargmin()
. This will allow the code to search for the minimum log likelihood while ignoring thenan
values. This approach will enable the code to proceed, but it should still output a warning to notify the user thatnan
values were present in the log likelihood list.