Deal with RST_STREAM in HalfClosedLocal state
#107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See detailed justification in the code itself.
| -- > error code of NO_ERROR after sending a complete response (i.e., a frame | ||
| -- > with the END_STREAM flag). | ||
| -- > A stream in the "open" state may be used by both peers to send frames | ||
| -- > of any type. (..) From this state, either endpoint can send a frame |
There was a problem hiding this comment.
Oh, (..) is just a standard way of indicating that some text was omitted. In this case, I only showed part of the spec that was relevant.
| -- | ||
| -- (emphasis not in original). This justifies the two non-error cases, | ||
| -- below. (Section 8.1 of the spec is also relevant, but it is less explicit | ||
| -- about the /either endpoint/ part.) | ||
| case (s, err) of |
There was a problem hiding this comment.
In the case of _otherwise, closed is called to delete the stream from the stream table.
I'm not sure but I guessclosed should be called in any cases.
So, closed should be moved to the outside of case.
There was a problem hiding this comment.
Makes sense. I guess I introduced that bug as part of #78, apologies. I've pushed a fix, but let me run my full test suite first before merging.
There was a problem hiding this comment.
Ok, all tests pass ✔️
|
Merged and released. |
|
Thanks @kazu-yamamoto ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See detailed justification in the code itself.
@kazu-yamamoto , just FYI, I'm getting closer to a first release of
grapesy, my new gRPC library that has motivated all of my PRs againsthttp2andhttp2-tls. Its own test-suite is still not 100% happy, I don't yet know if that will yield further PRs, butgrapesynow passes the full official gRPC interop test suite against both the Python reference and (after this PR fixing aRST_STREAMproblem), also against the C++ reference. There are a few more references to check, I have to deal with my own test suite failures, and then I still have to do some stress testing to see if there are any memory leaks, but we are getting closer to a stable product.