Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defining properWindowSize #66

Merged
merged 1 commit into from
Apr 6, 2023
Merged

defining properWindowSize #66

merged 1 commit into from
Apr 6, 2023

Conversation

kazu-yamamoto
Copy link
Owner

@akshaymankar I can reproduce #62 on CentOS and this PR should fix it.
@epoberezkin This PR might be workaround for #63, though, the download performance would get worse.

@epoberezkin
Copy link

Will test and report!

@epoberezkin
Copy link

Nope, not fully resolved yet! I am still struggling to configure armv7a VM to be able to test...

@kazu-yamamoto kazu-yamamoto merged commit f1743d7 into master Apr 6, 2023
@kazu-yamamoto kazu-yamamoto deleted the initial-window-size branch April 6, 2023 07:33
@akshaymankar
Copy link

Sorry for late response! I still see the WINDOW_UPDATE frames being sent from client even if the already streamed body is not consumed. After some point I see a RST_STREAM frame being sent from server after which the client stops.
I'd have thought the ideal solution for this would be for the receiver to not send WINDOW_UPDATE frames for the whole connection at all, but send it for particular streams, this way the sender could also stop generating more data if it can stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants