Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting rid of defaultLoc showing in logs #69

Closed
greydot opened this issue Sep 28, 2015 · 4 comments
Closed

Getting rid of defaultLoc showing in logs #69

greydot opened this issue Sep 28, 2015 · 4 comments
Assignees
@snoyberg

Comments

@greydot
Copy link

greydot commented Sep 28, 2015

What would be the easiest way to achive that? Frankly, @(<unknown>:<unknown> <unknown>:0:0) in logs doesn't carry much information.

My first choice was deriving instance Eq Loc, and then comparing the loc argument in defaultLogStr with defaultLoc, but then it looks like a hack.
@greydot
Copy link
Author

greydot commented Sep 28, 2015

greydot@c684ada

snoyberg added a commit that referenced this issue Sep 29, 2015
@snoyberg
Don't include source location for defaultLoc #69
520da39
@snoyberg
Copy link
Collaborator

I've just pushed a commit that gets rid of the defaultLoc output, which I think is the right behavior for the library. Can you test it out before I release to Hackage?

@greydot
Copy link
Author

greydot commented Sep 29, 2015

Works for me. Thanks.

@snoyberg
Copy link
Collaborator

Cool, released to Hackage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snoyberg snoyberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snoyberg @greydot