Fix test failure on Debian GNU/kFreeBSD (and probably GNU/Hurd) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this we get -Wimplicit-function-declaration warnings from GCC on non-Linux glibc-based architectures.
FreeBSD libc treats a NULL second argument to newlocale as equivalent to "C", but glibc returns an error in that case, causing a segfault shortly afterwards when passing a NULL locale to strftime_l/strptime_l.
kazu-yamamoto
added a commit
that referenced
this pull request
Jun 22, 2013
Fix test failure on Debian GNU/kFreeBSD (and probably GNU/Hurd)
|
Sorry for the delay. I have released new version. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pair of commits fixes a compiler warning and a test failure on at least Debian GNU/kFreeBSD (which uses the FreeBSD kernel but the GNU libc):
https://buildd.debian.org/status/fetch.php?pkg=haskell-unix-time&arch=kfreebsd-amd64&ver=0.1.2-3&stamp=1370013165
The GNU/Hurd failure looks similar, and I expect this to fix it too:
https://buildd.debian.org/status/fetch.php?pkg=haskell-unix-time&arch=hurd-i386&ver=0.1.2-3%2Bb1&stamp=1371051034