feat: disable the tab key with an option #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP tests. Need to find a way to assert this behavior Closes kazzkiq#81
|
Sorry for the delay, and thanks for the PR! It worked almost flawlessly (tested manually), but I'm also not sure how to make it testable via WebdriverIO. |
|
I came back to report the bug you already fixed in #82, so nice work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an option to disable the logic in
handleTab, as it was creating a keyboard trap. I left it enabled by default, but perhaps it would be better to default to a better keyboard accessibility experience (handleTabs: false)? I didn't want it to be a breaking change and require a major release.WIP tests – I wasn't sure how to assert this behavior. WebdriverIO indicates you can trigger keystrokes when inputting content with
setValue, but a series of characters including a tab sequence didn't produce the same result as a user typing. I wasn't sure how to use browser.sendKeys in this context either...so I'll take any suggestions on how to test this change.Closes #81