Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crocogorical tests #502

Merged
merged 55 commits into from
Dec 15, 2020
Merged

Crocogorical tests #502

merged 55 commits into from
Dec 15, 2020

Conversation

brifordwylie
Copy link
Collaborator

@brifordwylie brifordwylie commented Dec 14, 2020 •
edited
Loading

These are all the code changes and added test from @crocogorical, I've simply made a new branch to resolve merge conflicts and run local tests and add back some tests. Thanks SO much to @crocogorical for all the hard work, SO sorry for the very long delay in getting this code merged into master.

@crocogorical
Should raise the Error instead of returning it
9d5822f
@crocogorical
Move test data into a TestData class. Add more tests.
209a389
@crocogorical
Move reusable test data into TestData class. Add more tests, mainly f…
6497b76 
…or the Reader class.
@crocogorical
raise the Error, don't return it.
08c9188
@crocogorical
If __le is a class variable, it can be externally modified for testing.
ab4fb09
@crocogorical
Test the endianness and instance tests when initialising Writer.
5343532
@crocogorical
Remove the per-module test runners.
f59a1b2
@crocogorical
Add convenience property on TestData to return the shb/idb/epb tuple …
c2f206d 
…for le/be
@crocogorical
Add test for assignment of timestamp for epb
62a0c0e
@crocogorical
Test the repr metho of the SHB class.
b3cdb84
@crocogorical
_PcapngBlock should fail to unpack if we don't give it enough data.
9771340
@crocogorical
_PcapngBlock __len__ test with no opts
367144c
@crocogorical
Check that PostTest wrapper doesn't fail silently
390dfb6
@crocogorical
Check filedescriptor retrieval is accurate
3dacfef
@crocogorical
Check that epbs throw the correct exception if they don't get enough …
1471b18 
…data.
@crocogorical
EPB should not unpack if there is a length mismatch.
9a95478
@crocogorical
Rewrite test so coveralls doesn't penalize me.
bc76436
@crocogorical
Move system endianness check to Writer class variable
f210df8
@crocogorical
Rearrange tests, create test runners.
ec904e7
@crocogorical
setfilter should raise the Error, not return it
e837a1e
@crocogorical
More tests for the Reader class
d682180
@crocogorical
Test filedescriptor access and PostTest wrapper.
7de1773
@crocogorical
Catch failure to throw exceptions.
35ea386
@crocogorical
Check appropriate actions are taken for stange linktype and magic in …
b5e62e4 
…files.
@crocogorical
Tox will fail even if AssertionErrors are handled. Change PostTest te…
3296ff2 
…st to raise Exception instead.
@crocogorical
Test getitem access on Packet subclass.
2c90ce5
@crocogorical
Test pack_hdr on Packet class.
6b4c109
@crocogorical
Python2.6 throws a TypeError if we try to pack a tuple.
5996d67
@crocogorical
Test Q record property modifications. Move test data into TestData class
cb627ab
@crocogorical
Test loopback unpacking.
4f4ff97
crocogorical and others added 17 commits November 11, 2017 02:30
@crocogorical
Test the remaining parts of http.py
e174c21
@crocogorical
Call the test function under all circumstances.
36e1358
@crocogorical
Test invalid chunk length
f73d5fc
@crocogorical
Test string forms of request and response
5edf9b1
@crocogorical
pack_rdata tests
d78c68f
@crocogorical
Remove TXT and HINFO rpack tests until #395 is resolved.
b0ebbd8
@crocogorical
Test the unpack_rdata method elements for SOA/MX/AAAA/SRV/CNAME and i…
f2a3961 
…nvalid RR type value. Store the TestData elements as binascii.hexlify'ed data.
@crocogorical
Merge branch 'master' into testravaganza
a37dc3a
@crocogorical
Merge branch 'master' into testravaganza
8960376
@crocogorical
Add test for the new writepkts() function in pcapng.py.
96eaf0e
@crocogorical
Remove lines which run tests if pcap.py is executed.
43a8138
@crocogorical
Add test for detecting bad tcpdump header.
e364003
@crocogorical
Add test for file descriptor property on Reader.
b78ad55
@crocogorical
Test the loop() method of the dispatch approach
1a86814
@crocogorical
Use TestData class. Use readpkts during writer test.
fdee7d8
@brifordwylie
merging in the master branch and resolving merge conflicts
3063308
@brifordwylie
removing ordereddict support for 2.6 as we no longer support 2.6
24edd9e
@coveralls
Copy link

coveralls commented Dec 14, 2020 •
edited
Loading

Coverage Status

Coverage increased (+2.7%) to 92.354% when pulling 11190b2 on crocogorical_tests into 14c0110 on master.

@brifordwylie brifordwylie mentioned this pull request Dec 14, 2020
Closed
@brifordwylie
Copy link
Collaborator Author

Alright merging this PR... @crocogorical :)

@brifordwylie brifordwylie merged commit 91b7853 into master Dec 15, 2020
@brifordwylie brifordwylie deleted the crocogorical_tests branch December 15, 2020 16:02
@brifordwylie brifordwylie mentioned this pull request Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obormot obormot Awaiting requested review from obormot

@kbandla kbandla Awaiting requested review from kbandla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brifordwylie @coveralls @crocogorical