fix SCTP decoder DATA chunk padding and handling of .data field #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obormot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #499 and adds a unit test based on a pcap I found among Wireshark sample captures.
While working on the fix I noticed SCTP decoder incorrectly uses its
.datafield, basically copying.chunksas seen in this line:All other dpkt decoders utilize the
.datafor any bytes remaining after decoding all the known fields (header fields and.chunksin this case), leaving it for other decoders to pick up if necessary. I changed the sctp decoder to align with this convention and use.chunksinstead of.datawhen packing and unpacking. All existing unit tests pass without changes.