Use const pointers in more places + MSVC fixes #114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #109.
Switching to const pointers in image structure, and throughout the
codebase with -Wcast-qual warning to ensure that const pointers
are indeed not mutated. Also removed casts from allocation function
results - they're not necessary on
void *
pointers to any others.Using
const *
allows consumers to more easily reason about inputs /outputs of the API and safely share data between invocations or threads.
In the process I also fixed few more obvious UB warnings from clang-tidy
where it complained about usage of uninitialised data, although few more remain.
Also included few fixes for MSVC that got broken in #109.