PTV-225 Clarify sorting control #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasoniii
approved these changes
Dec 12, 2017
There was a problem hiding this comment.
Looks good to me.
I'm not 100% convinced that these icons are sufficiently clear, part of my brain wants to see a defined "up arrow" and "down arrow" instead of changing the way the boxes are stacked. But we can always change that later if it's disliked enough.
It certainly works as designed and is better than what's there currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might need another pass at this, but this changes the twin arrows button (in the list sort of the left-side data panel) to a hierarchy sorting button. This one - http://fontawesome.io/icon/sort-amount-asc/
It will then flip the icon and flip the sort order.
I'm not sure what's a better way to show this. This icon goes from "small" -> "large" (or the reverse), which I'm implying to be A -> Z for name / type sorting, or newest -> oldest for date sorting.