PTV-833 Fix genome icons in data panel #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiramisu24
reviewed
Dec 12, 2017
| // in order - entry.viewType > entry.type > parsing it out of the object_info type string. | ||
| var objectType = entry.type ? entry.type : object_info[2].split('.')[1].split('-')[0], | ||
| viewType = entry.viewType ? entry.viewType : entry.type; | ||
| viewType = viewType ? viewType : objectType; |
There was a problem hiding this comment.
viewType set twice seems pretty confusing. Maybe break it out into if statements?
There was a problem hiding this comment.
You're right. Got too clever for my own good. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent update replaced the genome icons in the data panel with the default icon (document). This brings them back.
The problem was with how the object type was getting interpreted by the new KBaseDataCard abstraction. I added a new "viewType" parameter to that (so the "type" string could continue to have things like the scientific name), and shuffled around how the actual data type gets read.
Also did a little bit of general cleanup on a few things.