Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves [KBASE-5410] #1220

Merged
merged 2 commits into from
Dec 13, 2017
Merged

resolves [KBASE-5410] #1220

merged 2 commits into from
Dec 13, 2017

Conversation

thomasoniii
Copy link
Contributor

This tacks on the KBase username to the globus link.

It also hides the globus link entirely if the user doesn't have globus as a provider. We may want to re-visit this to instead display a "signup for globus link" instead.

Also brings along two minor tweaks to the metadata - there's apparently a bug in the service wherein it may not hand back a line count or md5, this just adds some extra prettiness to the user to change the blank or NaN into "Not provided".

@thomasoniii thomasoniii changed the title resolves [TASK-5410] resolves [KBASE-5410] Dec 13, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 12.482% when pulling 3b47663 on staging-panel into 732e249 on develop.

@briehl briehl merged commit fa921da into develop Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants