Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Cleanup #1242

Merged
merged 5 commits into from
Jan 25, 2018
Merged

General Cleanup #1242

merged 5 commits into from
Jan 25, 2018

Conversation

briehl
Copy link
Member

@briehl briehl commented Jan 25, 2018

This PR will have some general cleanup tasks and minor bugfixes to get merged up to next and beyond.

  • PTV-225 (not sure where else to reference) - change data sort icons to be more descriptive when sorting by name or type (A->Z icon).
  • PTV-886 - no scrollbar in the Narratives panel in the Narrative interface.
  • bump version (probably minor version bump to reflect shiny new Import tools)
  • add release notes

@briehl
Copy link
Member Author

briehl commented Jan 25, 2018

There will probably be a few more tickets over the course of the day. I'll add these as I go.

@coveralls
Copy link

coveralls commented Jan 25, 2018

Coverage Status

Coverage decreased (-0.003%) to 12.586% when pulling 32a9f62 on briehl:develop into debf2eb on kbase:develop.

Copy link
Contributor

@thomasoniii thomasoniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks reasonable to me, no concerns.

The only thing I want to note (and not request to change) is that the sorting classes seem a little magic-number-ish to me. If for some reason we end up adding a third type of sorting class then I'd recommend breaking it out into a lookup table instead of hardwiring the classes.

Assuming the sort order is 0/1, then the setSortIcon call could become setSortIcon( sortClassForColumn[ '(date|name|type)' ][ self.sortOrder ] ), and then the lookup table be something along the lines of

{date : ['fa-sort-amount-asc', 'fa-sort-amount-desc']... }

But again, nothing I care to force right now, just noting it in case the number of classes grows in the future.

Otherwise, looks fine to me.

@briehl
Copy link
Member Author

briehl commented Jan 25, 2018

Agreed. If that grows in the future, we should rewrite that whole sorting feature to be more easily expandable. Thanks for the feedback!

@briehl briehl merged commit 6aa04e8 into kbase:develop Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants