Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataup 213 clear errors from staging #1870

Merged
merged 12 commits into from
Oct 21, 2020

Conversation

eamahanna
Copy link
Contributor

@eamahanna eamahanna commented Oct 16, 2020

Description of PR purpose/changes

This PR creates a clear all button when a file upload to the dropzone errors. The clear all button will remove all errored files from the dropzone when clicked. It will not remove files that are still uploading.

I talked to Mallory about the button positioning and she is fine with it's location given the scrolling functionality when there is more than a single errored file in the dropzone.

Screen Shot 2020-10-16 at 1 00 37 PM

Jira Ticket / Issue

https://kbase-jira.atlassian.net/browse/DATAUP-213

  • Added the Jira Ticket to the title of the PR e.g. (DATAUP-69 Adds a PR template)

Testing Instructions

  • Details for how to test the PR:
    To execute the unit tests, navigate to the narrative repo and enter make test-frontend-unit

To view this change locally, complete the following steps:

  • Pull this branch
  • Execute `kbase-narrative'
  • Create a new narrative
  • Navigate to the data import panel
  • Drag and drop a file that is greater than 20 GB into the dropzone. This should cause a file too large error.
  • Repeat to get a group of files in the dropzone that have errored
  • click the CLEAR ALL button
    This should clear the errored files from the drop zone.

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have run Black and Flake8 on changed Python Code manually or with git precommit (and the travis build passes)

Updating Version and Release Notes (if applicable)

@eamahanna eamahanna changed the base branch from develop to truss October 16, 2020 18:28
@coveralls
Copy link

coveralls commented Oct 16, 2020

Coverage Status

Coverage increased (+0.02%) to 16.983% when pulling dc7c41b on DATAUP-213-clear-errors-from-staging into a0b2820 on truss.

@eamahanna eamahanna marked this pull request as ready for review October 16, 2020 21:02
Copy link
Contributor

@leia-sefkin leia-sefkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment/question on this, overall looks good. Checked it out locally and works like a charm.

@eamahanna eamahanna force-pushed the DATAUP-213-clear-errors-from-staging branch from e5dd03f to dc7c41b Compare October 19, 2020 03:42
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@eamahanna eamahanna merged commit e4125e1 into truss Oct 21, 2020
@eamahanna eamahanna deleted the DATAUP-213-clear-errors-from-staging branch October 21, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants