-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataup 213 clear errors from staging #1870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamahanna
requested review from
briehl,
bio-boris,
ialarmedalien and
leia-sefkin
October 16, 2020 21:02
leia-sefkin
approved these changes
Oct 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment/question on this, overall looks good. Checked it out locally and works like a charm.
kbase-extension/static/kbase/js/widgets/narrative_core/upload/fileUploadWidget.js
Outdated
Show resolved
Hide resolved
eamahanna
force-pushed
the
DATAUP-213-clear-errors-from-staging
branch
from
October 19, 2020 03:42
e5dd03f
to
dc7c41b
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
This PR creates a
clear all
button when a file upload to the dropzone errors. The clear all button will remove all errored files from the dropzone when clicked. It will not remove files that are still uploading.I talked to Mallory about the button positioning and she is fine with it's location given the scrolling functionality when there is more than a single errored file in the dropzone.
Jira Ticket / Issue
https://kbase-jira.atlassian.net/browse/DATAUP-213
Testing Instructions
To execute the unit tests, navigate to the narrative repo and enter
make test-frontend-unit
To view this change locally, complete the following steps:
CLEAR ALL
buttonThis should clear the errored files from the drop zone.
Dev Checklist:
Updating Version and Release Notes (if applicable)