Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAUP-246: Consolidate css files in static/kbase/css directory #1882

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

ialarmedalien
Copy link
Collaborator

@ialarmedalien ialarmedalien commented Oct 22, 2020

Description of PR purpose/changes

Renaming and moving the styles from the nbextensions directory into the kbase-extension/static/kbase/css directory to make it easier to reorganise / convert to scss.

advancedViewCell/styles/main.css ==> advancedViewCell.css
editorCell/styles/main.css ==> editorCell.css

Removed css files with no content and an unreferenced file in the editorCell dir.
Edited the corresponding JS files to reference the moved files.

Jira Ticket / Issue

https://kbase-jira.atlassian.net/browse/DATAUP-246

Testing Instructions

  • Details for how to test the PR:
  • Tests pass in travis and locally
  • Changes available by spinning up a local narrative and clicking around to check there are no egregious css horrors (other than any that already exist). Check in the sources (or equivalent for your browser) panel that advancedViewCell.css and editorCell.css are loaded when you open a page.

Dev Checklist:

@coveralls
Copy link

coveralls commented Oct 22, 2020

Coverage Status

Coverage increased (+0.006%) to 16.983% when pulling 57b2cc2 on DATAUP-246_css_to_sass-cell_type_css into 86f459d on truss.

@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2020

SonarCloud Quality Gate failed.

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@briehl briehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ialarmedalien ialarmedalien merged commit 0322e93 into truss Oct 23, 2020
@ialarmedalien ialarmedalien deleted the DATAUP-246_css_to_sass-cell_type_css branch October 23, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants