-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAUP-266 staging refresh #1886
Conversation
kbase-extension/static/kbase/js/widgets/narrative_core/kbaseNarrativeStagingDataTab.js
Show resolved
Hide resolved
it('gets user info and parsed into whether or not the user is linked to globus', async () => { | ||
const $dummyNode = $('<div>'), | ||
stagingWidget = new StagingDataTab($dummyNode); | ||
const userInfo = await stagingWidget.getUserInfo(); | ||
expect(userInfo).toEqual({user: fakeUser, globusLinked: true}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra tests! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@@ -88,6 +88,12 @@ | |||
cursor: pointer; | |||
} | |||
|
|||
.kb-data-staging__container { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description of PR purpose/changes
As reported in DATAUP-266, when a user finishes uploading a file, the file viewer doesn't refresh automatically anymore. This restores that functionality. I also noticed some browser slowdown / lockup when uploading a lot of small files at one time, which trigger a refresh (and a
list
call to the staging service) when each file ends. If the files are small enough, or the user's upload speed is fast enough, this might cause problems. So the refresh is only allowed to run up to once per second.A side effect of this is setting the local
config.json
to use thedev
environment. This is currently needed to be able to run tests against CI, and will have no effect on either the built image or deployment.Jira Ticket / Issue
e.g. https://kbase-jira.atlassian.net/browse/DATAUP-X
Testing Instructions
Just upload a file, and it should refresh and appear right away.
Dev Checklist: