DATAUP-266 staging refresh #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbase-extension/static/kbase/js/widgets/narrative_core/kbaseNarrativeStagingDataTab.js
Show resolved
Hide resolved
Comment on lines
+86
to
+91
| it('gets user info and parsed into whether or not the user is linked to globus', async () => { | ||
| const $dummyNode = $('<div>'), | ||
| stagingWidget = new StagingDataTab($dummyNode); | ||
| const userInfo = await stagingWidget.getUserInfo(); | ||
| expect(userInfo).toEqual({user: fakeUser, globusLinked: true}); | ||
| }); |
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -88,6 +88,12 @@ | |||
| cursor: pointer; | |||
| } | |||
|
|
|||
| .kb-data-staging__container { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
As reported in DATAUP-266, when a user finishes uploading a file, the file viewer doesn't refresh automatically anymore. This restores that functionality. I also noticed some browser slowdown / lockup when uploading a lot of small files at one time, which trigger a refresh (and a
listcall to the staging service) when each file ends. If the files are small enough, or the user's upload speed is fast enough, this might cause problems. So the refresh is only allowed to run up to once per second.A side effect of this is setting the local
config.jsonto use thedevenvironment. This is currently needed to be able to run tests against CI, and will have no effect on either the built image or deployment.Jira Ticket / Issue
e.g. https://kbase-jira.atlassian.net/browse/DATAUP-X
Testing Instructions
Just upload a file, and it should refresh and appear right away.
Dev Checklist: